Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VAULT-6727 Role resolution for K8S Auth #156

Merged
merged 3 commits into from
Jul 21, 2022
Merged

Conversation

VioletHynes
Copy link
Contributor

Support role resolution functionality (to work with role based quotas). The intent of this operation is to take the same data as a login request and return the role that would be used in the request, so that we can quota upon login requests that have a certain role.

Afterwards, I will push a new tag and pull this new version into Vault.

@VioletHynes VioletHynes requested review from ccapurso and hghaf099 July 18, 2022 13:49
path_config_test.go Outdated Show resolved Hide resolved
Copy link
Contributor

@tomhjp tomhjp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just a couple of optional nits in the tests.

path_login_test.go Outdated Show resolved Hide resolved
path_login_test.go Show resolved Hide resolved
Copy link

@ccapurso ccapurso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

Copy link
Contributor

@tomhjp tomhjp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@VioletHynes VioletHynes merged commit ae75c7e into main Jul 21, 2022
@VioletHynes VioletHynes deleted the violethynes/VAULT-6727 branch July 21, 2022 17:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants